Skip to content

feat: Fail submission if packages have not been cleaned up for days #593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kalikiana wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: Fail submission if packages have not been cleaned up for days #593

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions trigger-openqa_in_openqa
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,11 @@ create_devel_openqa_snapshot() {
if [[ $staged_packages ]]; then
echo "+++ NOTE+++ Only triggering tests from $src_project (not overriding $staging_project and doing a submission) because $staging_project still contains packages. You might need to do a manual cleanup if no other pipeline is running. Packages: $staged_packages" \
| tee job_post_skip_submission
local staging_project_url="https://build.opensuse.org/project/show/$staging_project"
if curl -sL "$staging_project_url" | grep -q Days; then
echo "Stale packages have not been cleaned up in 1+ days. Check $staging_project_url"
return 1
fi
Comment on lines +125 to +129

@okurz okurz Jun 11, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The above comment says "You might need" so it's conditional. Also the message states "if no other pipeline is running" which isn't checked here. Are we sure this is the right condition to consistently fail on? What other situations can arise where this failure would just annoy as because we already know that we have a situation where there are still packages? What if package submissions are just pending acceptance for valid reasons?

@perlpunk perlpunk Jun 11, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also the message states "if no other pipeline is running" which isn't checked here.

We don't run pipelines in parallel, and for this case it wouldn't be a problem anyway.

Are we sure this is the right condition to consistently fail on? What other situations can arise where this failure would just annoy as because we already know that we have a situation where there are still packages? What if package submissions are just pending acceptance for valid reasons?

the testing project should always be cleaned after openQA tests have finished.
if there are still packages for longer, something went wrong. we can try to improve that situation by cleaning the project in more cases, but right now we have the situation that the whole submission process is blocked by this and noone notices if that happens.

but the implementation of the check won't work like that, as i wrote in my other comment

staging_project=$src_project
return
elif [[ -e job_post_skip_submission ]]; then
Expand Down