Skip to content

More consistent positioning of menu#28

Closed
corwin-of-amber wants to merge 1 commit into
os-js:masterfrom
corwin-of-amber:dom-changes-take2
Closed

More consistent positioning of menu#28
corwin-of-amber wants to merge 1 commit into
os-js:masterfrom
corwin-of-amber:dom-changes-take2

Conversation

@corwin-of-amber
Copy link
Copy Markdown
Contributor

This is a reattempt to get #27.

This is done by wrapping panel item content with a <div> and clamping
the context menu to it.
@corwin-of-amber
Copy link
Copy Markdown
Contributor Author

Ok I created a new one and still errors about using single quotes.

@corwin-of-amber
Copy link
Copy Markdown
Contributor Author

I noticed that all single-quoted strings have errors in Codacy, it only reports the ones in the diff upon submitting a PR.
https://app.codacy.com/manual/os-js/osjs-panels/issues/index?bid=8129109

@andersevenrud
Copy link
Copy Markdown
Member

Even though I disabled Cocay, it came back for unknown reasons. I disabled in in Github webhooks as well as the Codacy UI. I might just have to remove the repo link entirely or something.

I think the issue here is that Codacy don't read package.json, which is where I moved the eslint rules.

@andersevenrud
Copy link
Copy Markdown
Member

Closing, because #27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants