[codex] Fix open bug regressions and core build readiness#985
[codex] Fix open bug regressions and core build readiness#985mimeding wants to merge 9 commits intoosaurus-ai:mainfrom
Conversation
ef6aaa6 to
50da318
Compare
|
CI note: shellcheck, swiftlint, test-cli, and Release Drafter passed. test-core failed before running Osaurus tests with the known Xcode/SwiftPM C-module dependency resolution issue in EventSource dependencies (CAsyncHTTPClient, CNIOLLHTTP, CNIOExtrasZlib, CNIOPosix, _NumericsShims). Local validation on the rebased branch passed with |
| @@ -0,0 +1,39 @@ | |||
| --- | |||
|
Author-side cleanup complete. Verification:
Root cause addressed: stale DerivedData restore on PRs plus stale FluidAudio locks. This branch now keeps PR |
d6d1850 to
ed161c8
Compare
ed161c8 to
4540623
Compare
|
@tpae The line was removed, and this is now good to commit. Latest checks are green: test-core, test-cli, swiftlint, shellcheck, and Release Drafter. |
Business rationale: This keeps the open bug-fix bundle moving toward a green review state so users get the provider, chat-state, and CI reliability fixes without another stale-red PR blocking maintainer trust in the harness. Coding rationale: The rebase exposed strict touched-file lint failures after current main; the fix keeps provider wire shapes intact where omitted booleans are meaningful, rewrites multiline optional bindings into SwiftFormat- and SwiftLint-compatible forms, and preserves SwiftUI trace side effects with scoped lint suppressions because ViewBuilder cannot accept plain assignment expressions. Co-authored-by: Codex <codex@openai.com>
4540623 to
e3619d3
Compare
Business rationale
This PR clears several high-impact harness reliability bugs that make osaurus feel untrustworthy when users connect real providers, stream reasoning/tool calls, download models, or run sandboxed chat workflows. It advances the multi-provider, agent, sandbox, and file-safety pillars by making provider payloads round-trip correctly, keeping tests away from production chat-history storage, and making local capacity checks reflect what macOS actually reports.
Coding rationale
The fixes stay narrow and preserve existing public shapes: provider wire models keep optional booleans where omission and
falsehave different semantics, streamed reasoning/tool-call state is preserved instead of being flattened into visible chat text, and free-space checks are routed through URL volume resource keys rather than legacy filesystem attributes. The rebase cleanup also makes the touched files pass both SwiftFormat and SwiftLint without changing behavior; multiline optional bindings were split into small locals, and SwiftUI trace calls keep explicit discard bindings becauseViewBuildertreats plain assignment as an invalid view expression.What changed
reasoning_contentacross streamed and non-stream tool-call turns so follow-up requests can replay it.type: "message".OsaurusCorecompiles against the current resolved dependency set.origin/mainand make all touched Swift files pass strict formatting/lint.Fixes #980
Fixes #959
Fixes #964
Fixes #662
Validation
swift build --package-path Packages/OsaurusCoreswift build --package-path Packages/OsaurusCore -c releaseswift test --package-path Packages/OsaurusCorexcrun swift-format lint --strict <touched Swift files>swiftlint lint --strict <touched Swift files>git diff --check origin/main...HEADgit diff --checkNon-scope
Residual risks