Add a Main Visual to The Main Page - #38
Open
github-actions[bot] wants to merge 2 commits into
Open
Conversation
sn0wm1ku
reviewed
Mar 11, 2025
Member
There was a problem hiding this comment.
Nice try. I think its the first time @RedEffandy attemps to write a Vue component.
sn0wm1ku
reviewed
Mar 11, 2025
Member
There was a problem hiding this comment.
I think it is good for now but there are rooms to adjust left/right balance of the logo.
From the HTML formatting it is right in middle of the spaces but in human eyes is not. Going further is job for Designer.
sn0wm1ku
reviewed
Mar 11, 2025
sn0wm1ku
left a comment
Member
There was a problem hiding this comment.
We should ask Mike in next meeting about the visual to be used. Lets keep it in ice box at the mean while.
|
Got it, thanks for the feedback Alex. I'll keep this in the icebox for now. I'll also look further into CSS properties for positioning. (: |
Open
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. Target
2. Specification / Test Plan
(Text here)
3. Additional Instructions / Notes for Shipping (optional)
N/A
4. Check before Review Request
5. Evidence