Skip to content

Add a Main Visual to The Main Page - #38

Open
github-actions[bot] wants to merge 2 commits into
mainfrom
i37-20250311-1315
Open

Add a Main Visual to The Main Page#38
github-actions[bot] wants to merge 2 commits into
mainfrom
i37-20250311-1315

Conversation

@github-actions

@github-actions github-actions Bot commented Mar 11, 2025

Copy link
Copy Markdown

1. Target

2. Specification / Test Plan

(Text here)

3. Additional Instructions / Notes for Shipping (optional)

N/A

4. Check before Review Request

  • Self Review : I reviewed changes by myself and approved them.
    • Ensure there is no sensitive information, typos, unrelated changes, or debugging code.
  • Evidence : I attached evidences to prove the changes.
    • Record and attach a demo video. For minor changes, attaching an image is also acceptable.
    • Evidences should be updated to the latest version when further changes are made.

5. Evidence

image

@github-actions github-actions Bot added the addition A mirror label for the "Addition" issue type. label Mar 11, 2025
@RedEffandy RedEffandy changed the title Add a Vector Image to The Main Page Add a Main Visual to The Main Page Mar 11, 2025
@RedEffandy RedEffandy assigned sn0wm1ku and unassigned sn0wm1ku Mar 11, 2025
@RedEffandy
RedEffandy requested a review from sn0wm1ku March 11, 2025 07:35
@github-actions github-actions Bot added the ci-testing Enable a GitHub Action for unit testing on a pull request. label Mar 11, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice try. I think its the first time @RedEffandy attemps to write a Vue component.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is good for now but there are rooms to adjust left/right balance of the logo.
From the HTML formatting it is right in middle of the spaces but in human eyes is not. Going further is job for Designer.

@sn0wm1ku sn0wm1ku left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should ask Mike in next meeting about the visual to be used. Lets keep it in ice box at the mean while.

@RedEffandy

Copy link
Copy Markdown

@sn0wm1ku ,

Got it, thanks for the feedback Alex. I'll keep this in the icebox for now. I'll also look further into CSS properties for positioning. (:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

addition A mirror label for the "Addition" issue type. ci-testing Enable a GitHub Action for unit testing on a pull request.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Main Visual to The Main Page

4 participants