imgtestlib: handle missing sources key in tests#2447
Merged
Conversation
achilleas-k
previously approved these changes
Jun 19, 2026
achilleas-k
left a comment
achilleas-k
left a comment
Member
There was a problem hiding this comment.
Thanks for cleaning up the mess :)
achilleas-k
force-pushed
the
safe-access-curl2
branch
from
7546448 to
4fe724b
Compare
achilleas-k
force-pushed
the
safe-access-curl2
branch
from
4fe724b to
ba81ad7
Compare
lzap
previously approved these changes
Jun 22, 2026
achilleas-k
force-pushed
the
safe-access-curl2
branch
from
ba81ad7 to
2a5e3f1
Compare
Member
|
Ugh, sorry for breaking your PR (again). It seems I missed something in a recent change to the install-dependencies script. RHEL 7 builds on CentOS 9 machines, and boot testing the qcow2, which we're now doing in this PR with the removal of the I'll re-add the |
Prevent a KeyError crash when accessing org.osbuild.curl for missing sources. This commit also reconciles dropped changes in imgtestlib. During the time when the imgtestlib split PR was open [1], some changes were merged and the PR had to be rebased. During the rebase, I (AK) missed some of the changes that were already merged, essentially reverting them. I went through all functions that were in the monolithic imgtestlib and made sure to bring in all changes that were dropped and adapted them to newer changes. [1] osbuild#2383 Co-authored-by: Achilleas Koutsou <achilleas@koutsou.net>
achilleas-k
force-pushed
the
safe-access-curl2
branch
from
2a5e3f1 to
a4b9c72
Compare
achilleas-k
approved these changes
Jun 22, 2026
lzap
approved these changes
Jun 23, 2026
lzap
left a comment
lzap
left a comment
Contributor
There was a problem hiding this comment.
Thank you for looking into this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent a KeyError crash when accessing org.osbuild.curl for missing sources.
This commit also reconciles dropped changes in imgtestlib.
During the time when the imgtestlib split PR was open [1], some changes were merged and the PR had to be rebased. During the rebase, I (AK) missed some of the changes that were already merged, essentially reverting them.
I went through all functions that were in the monolithic imgtestlib and made sure to bring in all changes that were dropped and adapted them to newer changes.
[1] #2383