go.mod: add major version to module name#2453
Closed
achilleas-k wants to merge 3 commits into
Closed
Conversation
achilleas-k
force-pushed
the
go.mod/version
branch
from
ab00ddc to
b881fdd
Compare
thozza
previously approved these changes
Jun 22, 2026
Member
Author
|
Need to update import paths as well. |
We need this again to handle the migration to naming the module with a major version. Currently the blueprint imports image-builder with no major version in the module name, since we don't have one. As soon as add it here and import paths are updated, the same incompatibility we faced the last time will occur again: image-builder uses blueprint functions that take types from github.com/osbuild/image-builder but the types will instead be from github.com/osbuild/image-builder/v73.
achilleas-k
force-pushed
the
go.mod/version
branch
from
b881fdd to
a7641ad
Compare
Member
Author
|
Quite the mess we've made here. The blueprint interdependency is really making things weird. |
thozza
previously approved these changes
Jun 22, 2026
thozza
previously approved these changes
Jun 22, 2026
avitova
reviewed
Jun 23, 2026
avitova
left a comment
avitova
left a comment
Contributor
There was a problem hiding this comment.
There's few places where you put v73 into a GitHub link:)
| func describeImage(img *imagefilter.Result, out io.Writer) error { | ||
| // see | ||
| // https://github.com/osbuild/image-builder/pull/1019#discussion_r1832376568 | ||
| // https://github.com/osbuild/image-builder/v73/pull/1019#discussion_r1832376568 |
Contributor
There was a problem hiding this comment.
I think this is not on purpose?
| // This requires functional testing to ensure RHSM secrets discovery | ||
| // works correctly in the solver. | ||
| // See: https://github.com/osbuild/image-builder/issues/2055 | ||
| // See: https://github.com/osbuild/image-builder/v73/issues/2055 |
| } | ||
|
|
||
| // XXX: we should let the depsolver handle subscriptions: https://github.com/osbuild/image-builder/issues/2055 | ||
| // XXX: we should let the depsolver handle subscriptions: https://github.com/osbuild/image-builder/v73/issues/2055 |
Contributor
There was a problem hiding this comment.
This is a comment as well, and should not have v73, I think.
Contributor
There was a problem hiding this comment.
In this file there's also github links.
| } | ||
|
|
||
| // Workaround for lack of --target-imgref in Anaconda, xref https://github.com/osbuild/image-builder/issues/380 | ||
| // Workaround for lack of --target-imgref in Anaconda, xref https://github.com/osbuild/image-builder/v73/issues/380 |
| // Depsolve customization packages separately to avoid conflicts with base | ||
| // package exclusion. | ||
| // See https://github.com/osbuild/image-builder/issues/1323 | ||
| // See https://github.com/osbuild/image-builder/v73/issues/1323 |
| // Disabling dracut for ostree-based systems resolves this issue. | ||
| // Dracut will be run by rpm-ostree itself while composing the image. | ||
| // https://github.com/osbuild/image-builder/issues/624 | ||
| // https://github.com/osbuild/image-builder/v73/issues/624 |
| @@ -392,7 +392,7 @@ func (p *OSTreeDeployment) serialize() (osbuild.Pipeline, error) { | |||
| // mountpoints if its not present.This will safeguard | |||
| // any ostree deployment which has custom filesystem | |||
| // during ostree upgrade. | |||
| // issue # https://github.com/osbuild/image-builder/issues/352 | |||
| // issue # https://github.com/osbuild/image-builder/v73/issues/352 | |||
Member
Author
Welp. |
The release-action has been updated to handle bumping this, and it will add it if it's missing, but we want the next release to include the version so we can start importing image-builder by the tagged version as soon as we make the next release (v73.0.0). Changing the module name requires updating all import paths internally to match. The go.mod file now also has an indirect dependency on the older version of image-builder, without the version in the module name, because of the dependency loop with the blueprint library.
achilleas-k
force-pushed
the
go.mod/version
branch
from
3e05a40 to
89fecdb
Compare
Member
Author
|
All fixed. Thanks again! |
Member
Author
|
DRAFT: We're still discussing if we want to do this or if we're going to keep things unversioned. |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release-action has been updated to handle bumping this, and it will add it if it's missing, but we want the next release to include the version so we can start importing image-builder by the tagged version as soon as we make the next release (v73.0.0).