many: plumb sdboot options#2456
Open
supakeen wants to merge 1 commit into
Open
Conversation
supakeen
force-pushed
the
sync-bootctl
branch
2 times, most recently
from
2631a8b to
9b986bf
Compare
Contributor
|
I think it needs tests :) |
We introduced additional options for systemd-boot configuration but never actually plumbed them through into the configuration or definitions. Let's do that now so they can be set. Signed-off-by: Simon de Vlieger <cmdr@supakeen.com>
Member
Author
I've force-pushed a YAML definition test but since we don't have any actual image types that use this (at least, internally) I don't think I can add more than that, unless we want to add a boot test. The stage options were already tested JSON-wise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We introduced additional options for systemd-boot configuration but never actually plumbed them through into the configuration or definitions.
Let's do that now so they can be set.