Skip to content

spec: update composer-cli dependency to weldr-client#5096

Closed
yselkowitz wants to merge 1 commit into
osbuild:mainfrom
yselkowitz:patch-2
Closed

spec: update composer-cli dependency to weldr-client#5096
yselkowitz wants to merge 1 commit into
osbuild:mainfrom
yselkowitz:patch-2

Conversation

@yselkowitz

Copy link
Copy Markdown
Contributor

This was renamed long ago, and the Obsoletes/Provides for the old name was recently dropped:

osbuild/weldr-client@349392c

This was renamed long ago, and the Obsoletes/Provides for the old name was recently dropped:

osbuild/weldr-client@349392c

@brlane-rht brlane-rht left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm slightly opposed to changing this. weldr-client is technically the library and composer-cli is the cmdline tool provided by weldr-client. It's unlikely to happen, but leaving it like this allows it to be replaced by something else providing composer-cli.

@yselkowitz

Copy link
Copy Markdown
Contributor Author

Leaving this as is makes the tests subpackage uninstallable.

@supakeen supakeen requested review from supakeen and thozza April 15, 2026 05:01
@supakeen

Copy link
Copy Markdown
Member

Leaving this as is makes the tests subpackage uninstallable.

Would it also be fixed by re-adding the (probably erroneously dropped) Provides in weldr-client? That would probably make @bcl happy and the -tests package at the same time? 🙂

@yselkowitz

Copy link
Copy Markdown
Contributor Author

Would it also be fixed by re-adding the (probably erroneously dropped) Provides in weldr-client? That would probably make @bcl happy and the -tests package at the same time? 🙂

That would also fix it.

@brlane-rht

Copy link
Copy Markdown
Contributor

Ah! I didn't realize that had gotten lost in the change and when I looked at this yesterday using dnf repoquery I must have been looking at the wrong version :(
I've restored the Obsolete/Provides lines that got lost and started a rawhide build as well as an upstream PR at osbuild/weldr-client#189

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants