fix: night vision abuse and increased max world bound checks #73 - #74
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces improvements to player sync handling, specifically for night vision and thermal goggles, and expands the allowed world boundaries for position validation. The main changes add tracking for goggles usage and timing, update the sync logic to prevent unwanted firing when goggles are equipped, and adjust map boundary checks to allow a much larger playable area.
Player goggles sync improvements:
gogglesTickandgogglesUsedarrays to thePlayernamespace to track when goggles are equipped and how long they've been used (Player.cpp,Player.h). [1] [2]SyncProcessingto block the fire key when night vision or thermal goggles are equipped, and implemented a timer-based mechanism to prevent rapid toggling or firing while goggles are active (SyncProcessing.inl).Utils.hinSyncProcessing.hto support new timing logic.World boundary expansion:
ValidatePositionto support much larger map areas, and relaxed Z-axis bounds for more vertical freedom (Utils.cpp).