Skip to content

CI: pass --coverage to C/LDFLAGS when building JuliaInterface in treehash job#1343

Draft
fingolfin wants to merge 5 commits intomasterfrom
mh/CI-treehash-track-coverage
Draft

CI: pass --coverage to C/LDFLAGS when building JuliaInterface in treehash job#1343
fingolfin wants to merge 5 commits intomasterfrom
mh/CI-treehash-track-coverage

Conversation

@fingolfin
Copy link
Copy Markdown
Member

@fingolfin fingolfin commented Jan 31, 2026

There is a bunch of C code in JuliaInterface that we definitely are exercising, but which Codecov does not report as covered. I am trying to figure out why. One guess is that we only enable the CFLAG --cover when running the gap tests (in etc/ci_test.sh), so this PR tries to enable them also when running the JuliaInterface tests, at least in one case (the "treehash" CI check, as it already enables FORCE_JULIAINTERFACE_COMPILATION=true anyway).

UPDATE: alas, it doesn't work and I am not really sure why

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 31, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.90%. Comparing base (5f9a8d6) to head (2e3974b).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1343   +/-   ##
=======================================
  Coverage   80.90%   80.90%           
=======================================
  Files          61       61           
  Lines        4903     4903           
=======================================
  Hits         3967     3967           
  Misses        936      936           
Files with missing lines Coverage Δ
src/setup.jl 97.63% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fingolfin fingolfin force-pushed the mh/CI-treehash-track-coverage branch from c1d9c7c to f7eb1e3 Compare February 9, 2026 14:41
@fingolfin fingolfin force-pushed the mh/CI-treehash-track-coverage branch from f7eb1e3 to 0dbea59 Compare February 25, 2026 10:59
@lgoettgens
Copy link
Copy Markdown
Member

This has conflicts now...

@fingolfin fingolfin force-pushed the mh/CI-treehash-track-coverage branch from e47bc19 to 6cd3552 Compare February 25, 2026 12:28
@fingolfin fingolfin changed the title CI: pass --coverage to C/LDFLAGS when building JuliaInterface CI: pass --coverage to C/LDFLAGS when building JuliaInterface in treehash job Feb 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants