Revert "Hopefully fix the broken tutorials"#12
Conversation
This reverts commit 099f380.
|
We can't just revert that change, unfortunately. The new IJulia also subtly changes how they write their json (expanded over multiple lines in the old release v/s all in one line in the new release). It will also require the change from a974452 , and maybe some debugging in case that doesn't directly work. (The key part is adding |
|
It is possible the step to use the default project is not needed at all, since JuliaLang/IJulia.jl#928 was closed, and should be removed. Experimentation is required. |
|
Plus, in my opinion, it is not desirable to have the github action run on every pull request. |
aaruni96
left a comment
There was a problem hiding this comment.
See above comments (sorry, I am new to the review featureset)
I don't really care about the trigger, that was just part of the PR I reverted. This is just about dropping the version pin again. |
Sorry about that, the last release seems to have been even more breaking than I thought 🙃 If I understand correctly you need to remove the Docs for creating kernels are here: https://julialang.github.io/IJulia.jl/stable/manual/installation/#Installing-and-customizing-kernels |
|
With #14, the other changes by @aaruni96 should be obsolete. I've started a CI run to verify in https://github.com/oscar-system/TutorialTesterforOscar/actions/runs/19703572022. |
aaruni96
left a comment
There was a problem hiding this comment.
I think we still need these changes to install a new kernel which does not use the named project @, and just uses the default project?
(See #12 (comment) )
Co-authored-by: Aaruni Kaushik <aaruni96@users.noreply.github.com>
|
One can merge this once all tests pass on the action https://github.com/oscar-system/TutorialTesterforOscar/actions/runs/22950621386 Edit: This probably needs a new release of OSCAR (once Nemocas/AbstractAlgebra.jl#2361 trickles through the release process and into OSCAR), |
Nemocas/AbstractAlgebra.jl#2361 is available in AA v0.48.5, which is compatible with OSCAR v1.7.0. |
|
What is the status of this? @aaruni96 ? @lgoettgens ? |
|
This now runs into Nemocas/AbstractAlgebra.jl#2208, as the tests are performed with Oscar 1.5.1 (see #15), cf. https://github.com/oscar-system/TutorialTesterforOscar/actions/runs/24565614155/job/71824932191#step:9:40. Once CI works with the latest Oscar release, I can try to push this over the finish line |
Reverts #9
To be merged once Nemocas/AbstractAlgebra.jl#2209 is merged and released via Nemocas/AbstractAlgebra.jl#2210.