Conversation
Contributor
Author
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a new Track Context Menu UI container (replacing the previous se-infoblock-all root) and refactors the track info tab rendering to use shared tab panel components, with corresponding Selenium test updates.
Changes:
- Replace the legacy info block root container with a new
TrackContextMenu(se-track-context-menu) and header integration. - Refactor tab rendering into
TabPanels+PersistentTabPanel, and standardize track tab IDs viaTRACK_TAB_IDS. - Update Selenium selectors/waits from
se-infoblock-alltose-track-context-menuacross track/route-related tests.
Reviewed changes
Copilot reviewed 23 out of 23 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/selenium/src/tests/tracks/34-open-track-info-block.mjs | Updates waits/selectors to the new track context menu root ID. |
| tests/selenium/src/tests/tracks/33-visible-tracks.mjs | Updates “removed” assertions to match the new context menu root ID. |
| tests/selenium/src/tests/tracks/31-track-info-block.mjs | Updates text matching root element to se-track-context-menu. |
| tests/selenium/src/tests/tracks/25-create-track.mjs | Updates create-track flow to wait/match against the new context menu root. |
| tests/selenium/src/tests/navigation/42-route-info-block.mjs | Updates route info checks to use the new context menu root. |
| tests/selenium/src/tests/navigation/05-mini-create-route-srtm.mjs | Updates SRTM-related assertions to use the new context menu root. |
| tests/selenium/src/tests/menu/99-share.mjs | Updates share flow waits to the new context menu root. |
| tests/selenium/src/tests/menu/28-keep-layer-state.mjs | Updates persistence test to wait for the new context menu root (open/close). |
| tests/selenium/src/tests/map/15-map-context-menu.mjs | Updates route creation wait target to the new context menu root. |
| map/src/map/map.module.css | Re-formats font-family declaration for readability. |
| map/src/map/layers/TransportStopsLayer.js | Collapses a multi-line import into a single-line import. |
| map/src/infoblock/components/wpt/transport/transport.module.css | Normalizes hex color casing. |
| map/src/infoblock/components/wpt/transport/TransportStopsRoutes.jsx | Re-formats a useMemo expression. |
| map/src/infoblock/components/wpt/transport/TransportStopRouteDetails.jsx | Re-formats JSX props for readability. |
| map/src/infoblock/components/track/trackcontextmenu.module.css | Adds new styles for the Track Context Menu header/name row. |
| map/src/infoblock/components/track/TrackContextMenu.jsx | Introduces new track context menu container and header/name rendering. |
| map/src/infoblock/components/track/GeneralInfo.jsx | Removes in-panel track name editing UI (track name now shown in new context menu header). |
| map/src/infoblock/components/tabs/TrackTabList.js | Adds TRACK_TAB_IDS constants and uses them for tab keys/default tab. |
| map/src/infoblock/components/tabs/TabPanels.jsx | Adds shared tab rendering wrapper using MUI TabContext/TabList. |
| map/src/infoblock/components/tabs/SettingsTab.jsx | Removes unused Settings tab component. |
| map/src/infoblock/components/tabs/PersistentTabPanel.jsx | Extracts persistent tab mounting behavior into its own component. |
| map/src/infoblock/components/InformationBlock.jsx | Refactors info block rendering to use TrackContextMenu + extracted tab panel components. |
| map/src/frame/components/header/HeaderNoUnderline.jsx | Adds Selenium IDs to the close/back button for reuse in the new track context header. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.