Invert text/bg colors in dark mode#41
Open
grischard wants to merge 1 commit intoosmfoundation:masterfrom
Open
Conversation
Contributor
|
I'd advise against doing this. White text on a black background is hard to read for some people, which is why most "dark mode" stylesheets are not-really-white on dark-grey. Black text on a white background is fine, of course. I think this will also have issues with all the other colours on the site, such as the greys used for tables, link colours, etc etc. I would recommend that if you want to have a dark mode for this site, that you find a third-party theme where this stuff is figured out by other people! Recent versions of bootstrap (v5.3+) have a dark mode, for example, which handles these contrast and colour theory issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.