Updated urllib3 dependency to avoid dependabot vulnerability#256
Open
miguelgonrod wants to merge 1 commit into
Open
Updated urllib3 dependency to avoid dependabot vulnerability#256miguelgonrod wants to merge 1 commit into
miguelgonrod wants to merge 1 commit into
Conversation
Signed-off-by: miguelgonrod <miguelgonrod2004@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub Dependabot flagged a moderate security vulnerability in the default branch. https://github.com/osrf/buildfarm-tools/security/dependabot/1
urllib3< 2.5.02.5.0PoolManagerignores theretriesparameter, failing to disable redirects and potentially exposing the application to SSRF or open redirect vulnerabilities.As a comment in
requirements.txtsaid, this library was pinned in that version because some time ago it had a bug inDefault timeoutbut this was fixed in2024-09-30Remediation:
Update
requirements.txtto enforceurllib3>=2.5.0.Historical question
Is this really being used in any part? I can´t find any call to this dependency