Add sframe to backward libraries for static linking#97
Open
nvcyc wants to merge 1 commit intoosrf:rollingfrom
Open
Add sframe to backward libraries for static linking#97nvcyc wants to merge 1 commit intoosrf:rollingfrom
nvcyc wants to merge 1 commit intoosrf:rollingfrom
Conversation
Signed-off-by: CY Chen <cyc@nvidia.com>
|
Looks like there may have been an adjustment for this upstream (as we just vendor this package): bombela/backward-cpp#296 Maybe we just need to bump the vendored version? |
|
Oh yeah... it's been 5 years, probably about time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
sframeto static linking dependencies of thebfdlibrary.Without this dependency, it can cause undefined reference to
sframe_encoder_writeat runtime.