Skip to content

Clean up utility test setup #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GrahamCampbell merged 1 commit into from
Jun 8, 2026
Merged

Clean up utility test setup #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions test/unit/src/configuration/resolve-path.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
'use strict';

const fs = require('node:fs').promises;
const os = require('node:os');
const path = require('node:path');
const { expect } = require('chai');

Expand All @@ -12,7 +11,7 @@ describe('test/unit/src/configuration/resolve-path.test.js', () => {
let tmpDir;

beforeEach(async () => {
tmpDir = await fs.mkdtemp(path.join(os.tmpdir(), 'compose-resolve-path-'));
tmpDir = await fs.mkdtemp(path.join(process.cwd(), 'compose-resolve-path-'));
});

afterEach(async () => {
Expand Down
3 changes: 1 addition & 2 deletions test/unit/src/state/LocalStateStorage.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
'use strict';

const os = require('os');
const path = require('path');
const fsp = require('fs').promises;
const expect = require('chai').expect;
Expand All @@ -12,7 +11,7 @@ describe('test/unit/src/state/LocalStateStorage.test.js', () => {
let rootDir;

beforeEach(async () => {
rootDir = await fsp.mkdtemp(path.join(os.tmpdir(), 'compose-local-state-'));
rootDir = await fsp.mkdtemp(path.join(process.cwd(), 'compose-local-state-'));
await ensureDir(path.join(rootDir, '.serverless'));
});

Expand Down
5 changes: 2 additions & 3 deletions test/unit/src/utils/cache-hash.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

const fs = require('node:fs').promises;
const crypto = require('node:crypto');
const os = require('node:os');
const path = require('node:path');
const proxyquire = require('proxyquire');
const { expect } = require('chai');
Expand All @@ -25,7 +24,7 @@ describe('test/unit/src/utils/cache-hash.test.js', () => {
let tmpDir;

beforeEach(async () => {
tmpDir = await fs.mkdtemp(path.join(os.tmpdir(), 'compose-cache-hash-'));
tmpDir = await fs.mkdtemp(path.join(process.cwd(), 'compose-cache-hash-'));
});

afterEach(async () => {
Expand Down Expand Up @@ -87,7 +86,7 @@ describe('test/unit/src/utils/cache-hash.test.js', () => {
});

it('does not include file paths in cache hashes', async () => {
const otherDir = await fs.mkdtemp(path.join(os.tmpdir(), 'compose-cache-hash-other-'));
const otherDir = await fs.mkdtemp(path.join(process.cwd(), 'compose-cache-hash-other-'));

try {
await outputFile(path.join(tmpDir, 'one.txt'), 'content\n');
Expand Down
3 changes: 1 addition & 2 deletions test/unit/src/utils/fs.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

const fs = require('node:fs');
const fsp = fs.promises;
const os = require('node:os');
const path = require('node:path');
const proxyquire = require('proxyquire');
const sinon = require('sinon');
Expand All @@ -16,7 +15,7 @@ describe('test/unit/src/utils/fs.test.js', () => {
let tmpDir;

beforeEach(async () => {
tmpDir = await fsp.mkdtemp(path.join(os.tmpdir(), 'compose-fs-'));
tmpDir = await fsp.mkdtemp(path.join(process.cwd(), 'compose-fs-'));
});

afterEach(async () => {
Expand Down
3 changes: 1 addition & 2 deletions test/unit/src/utils/glob.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
'use strict';

const fs = require('node:fs').promises;
const os = require('node:os');
const path = require('node:path');
const { expect } = require('chai');

Expand All @@ -12,7 +11,7 @@ describe('test/unit/src/utils/glob.test.js', () => {
let tmpDir;

beforeEach(async () => {
tmpDir = await fs.mkdtemp(path.join(os.tmpdir(), 'compose-glob-'));
tmpDir = await fs.mkdtemp(path.join(process.cwd(), 'compose-glob-'));
});

afterEach(async () => {
Expand Down
4 changes: 0 additions & 4 deletions test/unit/src/utils/serverless-utils/log-reporters/node/progress-reporter.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,6 @@ const sinon = require('sinon');
const expect = chai.expect;

describe('test/unit/src/utils/serverless-utils/log-reporters/node/progress-reporter.test.js', () => {
afterEach(() => {
sinon.restore();
});

const loadProgressReporter = () => {
const handlers = new Map();
const cliProgressFooter = {
Expand Down
3 changes: 1 addition & 2 deletions test/unit/src/utils/spawn.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
'use strict';

const fs = require('fs').promises;
const os = require('os');
const path = require('path');
const { EventEmitter } = require('events');
const nodeStream = require('stream');
Expand Down Expand Up @@ -74,7 +73,7 @@ const assertRedaction = async ({ args, redacted, visible = [] }) => {

describe('spawn', () => {
it('executes PATH shims through cross-platform resolution', async () => {
const tempDir = await fs.mkdtemp(path.join(os.tmpdir(), 'spawn-shim-'));
const tempDir = await fs.mkdtemp(path.join(process.cwd(), 'spawn-shim-'));
const commandName = `spawn-shim-${process.pid}-${Date.now()}`;
const commandPath = path.join(
tempDir,
Expand Down
Loading