Replace various old packages#5
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR replaces a couple of deprecated/older dependencies with lightweight alternatives while preserving behavior via new unit tests (globbing semantics and serialized S3 state writes).
Changes:
- Replace
promise-queuewithp-limitinS3StateStorageand add a unit test ensuring concurrent writes are serialized. - Replace
globbywith a new localsrc/utils/globwrapper built onfast-glob, and add tests for leading negation patterns and directory-pattern expansion. - Update framework cache hashing tests to validate the new globbing behavior (directory patterns + re-inclusion via negation ordering).
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| test/unit/src/utils/glob.test.js | Adds coverage for leading negation handling in new glob helper (async + sync). |
| test/unit/src/state/S3StateStorage.test.js | Adds a concurrency test asserting state writes are serialized. |
| test/unit/components/framework/index.test.js | Adds cache-hash tests covering directory expansion and negation/re-inclusion semantics. |
| src/utils/glob.js | Introduces a fast-glob-based wrapper intended to replace globby. |
| src/state/S3StateStorage.js | Switches write serialization from promise-queue to p-limit(1). |
| package.json | Swaps dependencies: add fast-glob, remove globby and promise-queue (also removes uuid). |
| components/framework/index.js | Switches framework cache hashing from globby import to the new local glob helper. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
GrahamCampbell
marked this pull request as ready for review
April 23, 2026 00:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.