Skip to content

Replace various old packages#5

Merged
GrahamCampbell merged 3 commits into
mainfrom
replace-old-packages
Apr 23, 2026
Merged

Replace various old packages#5
GrahamCampbell merged 3 commits into
mainfrom
replace-old-packages

Conversation

@GrahamCampbell

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR replaces a couple of deprecated/older dependencies with lightweight alternatives while preserving behavior via new unit tests (globbing semantics and serialized S3 state writes).

Changes:

  • Replace promise-queue with p-limit in S3StateStorage and add a unit test ensuring concurrent writes are serialized.
  • Replace globby with a new local src/utils/glob wrapper built on fast-glob, and add tests for leading negation patterns and directory-pattern expansion.
  • Update framework cache hashing tests to validate the new globbing behavior (directory patterns + re-inclusion via negation ordering).

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
test/unit/src/utils/glob.test.js Adds coverage for leading negation handling in new glob helper (async + sync).
test/unit/src/state/S3StateStorage.test.js Adds a concurrency test asserting state writes are serialized.
test/unit/components/framework/index.test.js Adds cache-hash tests covering directory expansion and negation/re-inclusion semantics.
src/utils/glob.js Introduces a fast-glob-based wrapper intended to replace globby.
src/state/S3StateStorage.js Switches write serialization from promise-queue to p-limit(1).
package.json Swaps dependencies: add fast-glob, remove globby and promise-queue (also removes uuid).
components/framework/index.js Switches framework cache hashing from globby import to the new local glob helper.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread components/framework/index.js Outdated
Comment thread src/utils/glob.js
Comment thread test/unit/components/framework/index.test.js
Comment thread test/unit/components/framework/index.test.js
@GrahamCampbell
GrahamCampbell marked this pull request as ready for review April 23, 2026 00:27
@GrahamCampbell
GrahamCampbell merged commit 09365fd into main Apr 23, 2026
3 checks passed
@GrahamCampbell
GrahamCampbell deleted the replace-old-packages branch April 23, 2026 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants