Harden runtime spawn policy#394
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements the Step 4 runtime spawn hardening on 4.x. It adds a shared spawn input policy for async and sync wrappers, removes the remaining direct production child_process usage, migrates Java and Ruby invoke local execution onto spawnExt, validates Java and Ruby handler syntax before spawning, and sanitizes Java/Ruby runtime environment variables by default while adding --preserve-runtime-env as an explicit opt-in.\n\nI verified the change with the focused spawn and invoke-local unit tests, targeted ESLint and Prettier checks, the production raw-process grep, git diff --check, npm run lint:updated, npm run prettier-check:updated, npm run lint, npm run prettier-check, and npm test.