Fix empty Spark graph opening shift for v0.3.2 - #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
first hidden layout frame, so a manually opened empty chart cannot move left
when Cinnamon finishes the disclosure animation.
and add a source-level lifecycle regression.
Security and privacy impact
None. Codex authentication, subprocess execution, analytics/history data,
local settings and screenshots are unchanged. The change only affects popup
layout styling and contains no account-specific values, credentials, private
paths or new captured media.
Verification
make check(viamake verifyon commit5a6384561830b8989ed60ca17cb9903b1fe5b415)synchronized nested-chart insets use one layout path.
validated on the live right/vertical placement.
and positive-activity/automatic-open states.
in code, fixtures, logs or screenshots.
feature set and screenshots remain current.
opening frames; before the fix it moved from x=1504 to x=1499.
no mismatches; the live 0.3.2 instance had a healthy snapshot and no
error.