Skip to content

event_log is written throughout the relay but never displayed #183

Description

@Phlabry

Describe the bug
State::log_event (relay/src/state.rs:237-240) has 12 call sites covering most connect and disconnect failure paths, but event_log is never read by relay/src/view.rs. It is a write-only vector that also grows without limit and is never flushed to disk.

This is the root cause that makes the failures in #179 and #180 invisible.

Expected behavior
Either the log is rendered in the GUI, or it is removed and the call sites are changed to something the user can see.

Additional context
human_log writes to stderr separately, which is lost when the GUI is not started from a terminal.

Found while writing the setup documentation in #138 / #178.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingrustPull requests that update rust code

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions