Skip to content

rust-toolchain file is misnamed, so the toolchain is not pinned #188

Description

@Phlabry

Describe the bug
The file at the repository root is named toml .rust-toolchain.toml, with a leading toml in the filename. rustup only reads rust-toolchain.toml or rust-toolchain, so it is ignored. Nothing is pinned locally or in CI; both use whatever stable is installed.

The README claimed twice that the toolchain was pinned. PR #178 corrected the README text but not the file.

Expected behavior
Either the file is renamed so the pin takes effect, or it is deleted so it stops implying a pin that does not exist.

Additional context
Renaming is not a safe one-line fix. The file pins channel = "1.80.0", and relay depends on chrono 0.4.42 and an unpinned iced, which may not build on 1.80. Whoever takes this should verify a full build on the pinned version before renaming, or raise the pin to something tested.

Found while writing the setup documentation in #138 / #178.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingrustPull requests that update rust code

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions