Conversation
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
inference/README.md still documents the removed Unicode encoding issue and workaround.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
What changed in this PR
This PR removes Unicode status emojis from relay output and inference-script logs to avoid Windows encoding failures when output is redirected or piped.
Changes:
- Replaces emoji markers with ASCII tags in Rust relay messages.
- Replaces emoji markers in inference logging and output.
- Updates the relay output example in the root README.
| File | Description |
|---|---|
relay/src/view.rs |
Uses an ASCII warning marker in the UI. |
relay/src/state.rs |
Uses ASCII success/error markers for listener status. |
README.md |
Updates the relay output example. |
inference/train_model.py |
Uses ASCII markers for training and save messages. |
inference/test_model.py |
Uses ASCII markers throughout testing output. |
inference/label_generator.py |
Uses ASCII markers and removes arrow-comment characters. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
|
||
| self.model = joblib.load(model_path) | ||
| logger.info(f"✓ Model loaded successfully: {type(self.model).__name__}") | ||
| logger.info(f"[OK] Model loaded successfully: {type(self.model).__name__}") |
Collaborator
|
LGTM overall. No non-ASCII left on the branch, README samples match the new relay output, CI green. One thing before I approve:
Nits, ignore if you want:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed emojis that caused issues in #193