handle negative amounts in calculate rate correctly#14
Merged
SharonGrossman merged 2 commits intomainfrom Apr 17, 2025
Merged
Conversation
SharonGrossman
requested review from
danielwitz and
noamokman
and removed request for
noamokman
noamokman
reviewed
Apr 17, 2025
Comment on lines
+282
to
+283
| expect(calculateRate({ value: -1000, currency: 'USD' }, { value: -800, currency: 'EUR' })).toBe(0.8); | ||
| expect(calculateRate({ value: -1000, currency: 'USD' }, { value: -1000, currency: 'GBP' })).toBe(1); |
Contributor
There was a problem hiding this comment.
pretty sure these worked before
Contributor
There was a problem hiding this comment.
if you changed apply rate you should add tests for those cases in the apply rates function tests
Contributor
Author
There was a problem hiding this comment.
if only one of the amounts is negative, it's coming out negative
also - fixed, my bad, i altered the apply rate and not the calculate rate
noamokman
approved these changes
Apr 17, 2025
danielwitz
approved these changes
Apr 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.