fix: handle null response in HttpTarget to prevent NPE#116
Merged
Conversation
OkHttp's async callback can receive a null response when the call times out or fails (e.g. connection error). The batch call handler and onExecutionSuccess dereferenced response without a null check, causing NullPointerException and process exit (CrashLoopBackOff in container environments). - Batch call: compute statusCode and body string with null checks; use -1 when response is null so retry/DLQ logic still runs. - Single-record onExecutionSuccess: early return when response is null; report to monitor, optionally produce to DLQ, and return failed future instead of NPE in try-with-resources. Co-authored-by: Cursor <cursoragent@cursor.com>
guysegal
approved these changes
Feb 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OkHttp's async callback can receive a null response when the call times out or fails (e.g. connection error). The batch call handler and onExecutionSuccess dereferenced response without a null check, causing NullPointerException and process exit (CrashLoopBackOff in container environments).