Skip to content

Rationalisation des organisations (1/2)#3714

Open
arnaudlevy wants to merge 10 commits into
mainfrom
merge-organizations-step1
Open

Rationalisation des organisations (1/2)#3714
arnaudlevy wants to merge 10 commits into
mainfrom
merge-organizations-step1

Conversation

@arnaudlevy

@arnaudlevy arnaudlevy commented Jan 19, 2026

Copy link
Copy Markdown
Member

C'est la préparation de l'infrastructure pour faire la fusion :

  • Les 3 booléens qui définissent l'existence des facettes
  • Les classes qui gèrent le lien avec Hugo
  • Un service qui liste les objets à fusionner en phase 2

@qltysh

qltysh Bot commented Jan 19, 2026

Copy link
Copy Markdown

❌ 3 blocking issues (3 total)

Tool Category Rule Count
qlty Duplication Found 73 lines of similar code in 3 locations (mass = 104) 3

@arnaudlevy

Copy link
Copy Markdown
Member Author

@SebouChu minitest est passé en 6, et ça foire les tests :/ T'en penses quoi ?

@arnaudlevy arnaudlevy marked this pull request as ready for review January 23, 2026 10:09
"#{about.class.polymorphic_name.parameterize}-laboratory-#{self.about_id}"
end

end

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found 73 lines of similar code in 3 locations (mass = 104) [qlty:similar-code]

"#{about.class.polymorphic_name.parameterize}-location-#{self.about_id}"
end

end

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found 73 lines of similar code in 3 locations (mass = 104) [qlty:similar-code]

"#{about.class.polymorphic_name.parameterize}-school-#{self.about_id}"
end

end

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found 73 lines of similar code in 3 locations (mass = 104) [qlty:similar-code]

Comment thread db/schema.rb
t.string "html_class"
t.jsonb "metadata"
t.string "migration_identifier"
t.boolean "native", default: false

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rien à faire là

@pabois pabois left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Un détail sur le schema, sinon ça me semble ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants