Job de suppression d'université#4110
Open
SebouChu wants to merge 3 commits into
Open
Conversation
arnaudlevy
reviewed
Jun 16, 2026
arnaudlevy
left a comment
arnaudlevy
left a comment
Member
There was a problem hiding this comment.
La logique est impeccable, mais les listes devraient être dans les modèles, pas dans un job, c'est trop important.
| class DestroyUniversityJob < ApplicationJob | ||
| queue_as :whales | ||
|
|
||
| OBJECTS_NOT_PARANOID = [ |
Member
There was a problem hiding this comment.
ça c'est vraiment intéressant, je trouve. Ca devrait être dans un endroit plus structurel, dans le namespace osuny, dans les modèles, je trouve.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type
Description
Destruction
Niveau d'incidence