Papiers : ajout d'une liste et suppression d'un doublon de schema#1568
Merged
Conversation
Olivia206
requested review from
SebouChu,
alexisben,
arnaudlevy and
pabois
as code owners
Contributor
djLintHugolintDirectories are perfect ✅Partials calls are perfect ✅Lines are perfect ✅Complexity is perfect ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type
Description
Plusieurs problèmes :
_partials/papers/single/authors.html, on avait la déclaration du schema d'une personne avec des metadata, mais_partials/persons/partials/person.htmlfait déjà le schema inline ;person.htmlgénère unlimaisauthors.htmlne déclare aucuneulEn conséquence, on se retrouve avec une puce depuis le retrait des
@include list-reset:On enlève donc les metadata de
authorset on remplace ladiv.authorpar unul, le schema se fait bien. On ajoute ensuite les métadonnées manquantes àperson.html, cette fois directement dans deux balises meta.(Pas certaine que ce soit le meilleur endroit pour mettre ces meta)
.
Niveau d'incidence
URL de test du site example
http://localhost:1313/fr/blocks/blocs-de-liste/organigramme/URL de test du site example journal
http://localhost:1313/papiers/2022-02-10-qualite-front-aaa/Screenshots