Repository navigation
test: wait for the boot-up after restore --reset - #17
Merged
Merged
Conversation
TestStoreRestore waited for the defaults, which return when the reset runs; the node's SDO server stays fenced until its boot-up, so the next SDO request timed out on a slow runner (CI run 41920045229, Race Go 1.24; 3 of 40 runs under local CPU load, 0 of 80 now). Wait for Pre-operational, which the boot-up enters after opening the server. The interop restore scenario waits for an SDO answer for the same reason. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the
TestStoreRestoreflake in CI run 41920045229 (exit 5, want 0: SDO timeout on0x1011:02).The test waited for the dictionary defaults, which return when the reset runs. The node fences its SDO server at the reset and opens it at boot-up, so the next
restorerequest fell into that gap on a slow runner (race detector, Go 1.24).The test now waits for Pre-operational, which
nmt.Slave.bootUpenters after the boot-up handler opens the server. The interoprestorescenario waits for an SDO answer before the next scenario, for the same reason.Under local CPU load, the old test failed 3 of 40 runs and the fixed one 0 of 80. Test-only change; no release needed.
🤖 Generated with Claude Code