Repository navigation
ci: optional self-interop against the published go-sunspec image - #25
Merged
Merged
Conversation
- interop: the tests run per peer; the adapter otfabric runs only when SUNSPEC_INTEROP_OTFABRIC_IMAGE names an image (never a default), and SUNSPEC_INTEROP_ADAPTERS selects a subset. Tests renamed to TestGoReadsPeerDevice, TestPeerReadsGoServer, TestPeerWritesGoServer; the write test skips a peer that declares no client write. - .github/workflows/self-interop.yml, copied from go-modbus: manual only, :latest, logs the digest, never required. - CONTRIBUTING.md, INTEROPERABILITY.md, TESTING.md paragraphs. No library change, no release. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The library half of ADR-0012 for SunSpec (harness half: otfabric/sunspec-interop#4).
interop/: each test runs per peer adapter.pysunspec2as before (pinned digest,SUNSPEC_INTEROP_PYSUNSPEC2_IMAGEoverrides);otfabric, a released go-sunspec assunspec-interop-otfabric, only whenSUNSPEC_INTEROP_OTFABRIC_IMAGEnames an image — never a default.SUNSPEC_INTEROP_ADAPTERSselects a subset. Tests renamedTestGoReadsPeerDevice,TestPeerReadsGoServer,TestPeerWritesGoServer; the write test skips a peer whose capabilities declare no clientwrite(otfabric: go-sunspec's client reads only)..github/workflows/self-interop.yml, copied from go-modbus: manual only,:latest, logs the digest, never required, nothing pinned.Nothing in the module changes, so no release.
Local run (macOS arm64) with
SUNSPEC_INTEROP_OTFABRIC_IMAGEset to a locally built image of the harness branch: all pass, the otfabric write test skipped. It found an adapter bug in the harness (an acc64 scaled value through float64), fixed there. Self-interop from this branch runs once the image is published.🤖 Generated with Claude Code