Repository navigation
Fail the image job when the interop run fails - #17
Merged
Merged
Conversation
A run step is bash -e without pipefail, so the tee behind scripts/interop.sh hid a failed run and the image would still be published. The same bug showed 16 hidden failures in iec104-interop's image job. The logs of the last image job here show 0 failed, so no published image is affected. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A plain
run:step isbash -ewithoutpipefail, soscripts/interop.sh ... | tee reports/interop.loghides a failed run. The job goes on, and onmainit would publish the image. The same bug hid 16 failures on the iec104-interop branch, where its fix is part of that PR.opcua-interopalready runs that step withpipefail.The last image job here (run 41347012005) logged 4394 passed and 0 failed on both architectures, so the image it published is not affected.
No failing run was forced in this repository. The behaviour was checked by running
bash -e -c 'false | tee /dev/null; echo continues'.🤖 Generated with Claude Code