Repository navigation
test: cover the patch lines Codecov reported on #16 - #17
Merged
Merged
Conversation
Codecov patch coverage of #16: the *ocpp.CallError branches of the CSMS answerer (an action the version does not have) and the timer path of waitBoot (a Pending interval that runs out). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Covers the lines that Codecov reported as missed in #16 (patch coverage 98 %, 5 lines):
internal/csms/answer.go: the*ocpp.CallErrorbranches oferrorCodeandanswer. go-ocpp's validator returns a NotImplemented CallError for an action the version does not have.TestUnknownActionIsNotImplementedcovers both branches.internal/station/station.go: the timer path ofwaitBoot, where a Pending interval runs out and the station sends BootNotification again.TestBootPendingRetriesAfterIntervalcovers it.internal/script/run.go: Codecov marked the step-timeout loop indialas a partial. Go records only statement coverage, and that line is executed, so there is nothing more to cover there.Only tests change; there are no code changes.
🤖 Generated with Claude Code