Repository navigation
chore: Go 1.26, go-s7comm v0.9.0, SAST fixes and hardening - #15
Merged
Merged
Conversation
- go 1.26, go-s7comm v0.9.0, go-cotp v1.2.0, go-tpkt v1.1.0; go fix. - record creates its output 0600; replay, record and pcap-decode clean file paths (gosec G302, G304). - A go-s7comm ValidationError exits 2 (usage) instead of 6. - Tests: S7ANY range limits, record file mode, fuzz targets for TPKT frames read from a peer and for replay scripts. - CI on Go 1.26 and 1.27; golangci-lint v2.15.0. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
write --db 65537wrote to DB 1.go fixapplied, CI on Go 1.26 and 1.27. The Makefile's golangci-lint pin moves to v2.15.0 (v2.11.3 cannot read Go 1.27 export data).make sast, low/low): 2 → 0 open.recordcreates its output 0600 (G302);replay,recordandpcap-decodeclean file paths (G304).*client.ValidationError(nothing sent) exits 2 (usage) instead of 6 (protocol). Documented in docs/exitcodes.md and RELEASE.md.FuzzReadTPKTFrameandFuzzLoadReplayScript.Test plan
make check(lint, vet, govulncheck, race tests, per-package coverage floor), total coverage 98.4 %make e2ego vetfor linux/386 and windows/amd64, build for linux/arm/v7make sast REPO=s7commctl SEVERITY=low CONFIDENCE=low REF=chore/go126-sast: PASS🤖 Generated with Claude Code