Repository navigation
own/go-sunspec: client write with go-sunspec v0.10.0 WritePoint - #5
Merged
Merged
Conversation
- The otfabric adapter declares clientOperations [scan, write]: write is go-sunspec's Device.WritePoint (raw value -> engineering with the device's scale factor, read back raw). Builds need go-sunspec >= v0.10.0. - SAST of own/go-sunspec clean at low/low: bounded integer conversions, fixtures read through os.Root (regular files, 1 MiB), ready file 0600. - scripts/smoke.sh: a usage message opengrep could not parse. - Docs: own README, CAPABILITIES. Cross-stack with otfabric: 24 passed, 0 unsupported (was 20 + 4). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the capability gap left by #4: the
otfabricadapter now declares the client operationwrite, using go-sunspec v0.10.0's newDevice.WritePoint(otfabric/go-sunspec#26).client write: the contract's raw value becomes the engineering value go-sunspec takes (raw × 10^sf with the scale factor the device reports); go-sunspec writes only the point's registers (FC 16) and reads back;valueis the raw value read back. A non-RW point is refused by go-sunspec before sending (exit 1).engineering/sast/scan.sh --module-dir own/go-sunspec, low/low): 10 gosec findings fixed in code, none triaged — bounded integer conversions, fixtures read throughos.Root(regular files ≤ 1 MiB), ready file 0600.scripts/smoke.sh: a usage message opengrep could not parse. Rescan: 0 findings, complete.own/go-sunspec/README.md,docs/CAPABILITIES.md.No harness release: the own image is not part of one, and nothing else changes behaviour.
Validation (local)
make -f own/go-sunspec/Makefile image smoke interop(go-sunspec v0.10.0, references v0.2.0 as published and as built from this branch): smoke 8/8, cross-stack 24 passed, 0 unsupported (was 20 + 4 unsupported).TestPeerWritesGoServer/otfabricandTestGoWritesPeerDevice/otfabricpass.make ci: reference self-test unchanged (8/8, 6/6).After merge: run Own stack (go-sunspec) from main →
:v0.10.0and:latest.🤖 Generated with Claude Code