Repository navigation
Go 1.26, hostile-input hardening, go-sunspec v0.9.0 (v0.5.0) - #19
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- Text output, serve's write log and error messages escape control characters, escape sequences, bidi overrides and invalid UTF-8 from device data (a device could clear the screen or forge output lines). - capture/template -o write 0600 via temp file + rename and refuse symlinks and non-regular files (exit 10); the old file survives. - serve --file is capped at 16 MiB and TLS files at 4 MiB (exit 3). - poll, poll-model and poll-point stop on interrupt during discovery. - Text write errors exit 10; non-positive --timeout/--interval, negative --count and --unit-id 0 are usage errors (exit 2). - detect docs match the code (exit 1 without the SunS marker). - Hostile device/input tests and two fuzz targets. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Out-of-range scale factors are no longer applied by go-sunspec; the hostile test now asserts the unscaled point. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prepares v0.5.0 (RELEASE.md has the details).
go fix, shared workflows v3.3.1; go-sunspec v0.9.0 and go-modbus v1.11.1.capture -o/template -owrote 0644, followed symlinks and truncated before writing; now 0600, temp + rename, links refused (exit 10);serve --fileand TLS files read with no size limit (/dev/zero);poll*ignored Ctrl-C during discovery; text write errors exited 0;--timeout/--interval, negative--count,--unit-id 0silently misused, now exit 2.FuzzTermSafeandFuzzTextOutput; coverage 99.4 → 99.5 %.make checkandmake e2egreen locally.🤖 Generated with Claude Code