Skip to content

fix: address 11 bugs found in codebase review - #71

Merged
oth-body merged 1 commit into
masterfrom
fix/codebase-review-bugs
Sep 15, 2026
Merged

oth-body merged 1 commit into
masterfrom
fix/codebase-review-bugs

Conversation

@oth-body

Copy link
Copy Markdown
Owner
  1. Fix eventCache shadowing with := in main() — use plain =
  2. Fix getDMs() nip04.Decrypt using raw privateKey instead of computed shared secret
  3. Fix text input not updated for cursor states 51 and 200 in TUI login
  4. Fix NIP-89 a tag format from pubkey:d:kind to kind:pubkey:d
  5. Fix NIP-89 handler registration kind 1984 → 31990 with d tag
  6. Add bounds check len(tag) > 1 before accessing tag[1] in findHandlers
  7. Capture withLoading errors for DMs and Replies instead of discarding
  8. Fix context leak: call cancel() immediately instead of defer in relay loop
  9. Add upper bound clamp (max 7) for Home screen cursor
  10. Fix publishToAllRelays to only error when zero relays succeed
  11. Check GetPublicKey and Sign errors in publishPostTUI

1. Fix eventCache shadowing with := in main()
2. Fix getDMs() nip04.Decrypt using raw key instead of shared secret
3. Fix text input not updated for cursor states 51 and 200
4. Fix NIP-89 "a" tag format (kind:pubkey:d instead of pubkey:d:kind)
5. Fix NIP-89 handler registration kind 1984 -> 31990 with "d" tag
6. Add bounds check before accessing tag[1] in findHandlers
7. Capture withLoading errors for DMs and Replies actions
8. Fix context leak from defer cancel() inside relay loop
9. Add upper bound clamp for Home screen cursor
10. Fix publishToAllRelays returning error on first failure
11. Check GetPublicKey and Sign errors in publishPostTUI
@oth-body
oth-body merged commit c3e667a into master Sep 15, 2026
7 checks passed
@oth-body
oth-body deleted the fix/codebase-review-bugs branch September 15, 2026 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant