Add interest bearing mint extension#3278
Closed
Bhargavamacha wants to merge 17 commits into
Closed
Conversation
|
@luke-truitt is attempting to deploy a commit to the coral-xyz Team on Vercel. A member of the Team first needs to authorize it. |
Bhargavamacha
changed the title
acheroncrypto
requested changes
Sep 26, 2024
Collaborator
acheroncrypto
left a comment
acheroncrypto
left a comment
There was a problem hiding this comment.
Thanks, it's looking great, but it would be better if we had a test case for this in the token-extensions tests.
It would also be helpful to mention feature in the CHANGELOG.
Contributor
Author
|
@acheroncrypto updated tests and added to CHANGELOG |
Collaborator
|
What is currently blocking this from being merged? |
Contributor
Author
|
nothing from my side @acheroncrypto could you have a look |
Collaborator
|
I believe this needs updating for V1, including moving the changelog entry to the correct location |
Collaborator
|
Closed for #4464 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.