Support for additional Token22 extensions#3701
Closed
Ikrk wants to merge 5 commits into
Closed
Conversation
Collaborator
|
Hey @Ikrk , can you rebase? |
73dd177 to
60dc2ab
Compare
|
@Ikrk is attempting to deploy a commit to the Solana Foundation Team on Vercel. A member of the Team first needs to authorize it. |
Author
60dc2ab to
7b3e1e9
Compare
7b3e1e9 to
f316c59
Compare
Author
|
Hey @tiago18c , I have fixed the formatting issue. Can you please approve and re-run the workflows? Thanks! |
Collaborator
|
Some of these have been implemented elsewhere:
In the interests of reducing open PRs and because there are significant conflicts here, I'm going to close this. Feel free to open separate PRs for the transfer fee and default account state extensions, including rebasing and updating error codes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
this PR extends the original Token22 Extensions PR #2789 and adds support for additional token mint extensions, namely:
An example of initialization:
An example of constraints check:
Checking of constraints
extensions::transfer_fee::basis_points,extensions::transfer_fee::max_feeandextensions::interest_bearing::rateis currently not supported.Also I was wondering if it would not be better to have ex.
extensions::non_transferable = falseinstead of only being able to check if the non-transferable extension is enabled?Fixes #3088.
Let me know what you think. Thanks!