Skip to content

fix(v2): re-check mut_mask on remaining_accounts walk#4441

Open
jamie-osec wants to merge 3 commits into
otter-sec:anchor-nextfrom
jamie-osec:fix/v2-remaining-accounts-mut-check
Open

fix(v2): re-check mut_mask on remaining_accounts walk#4441
jamie-osec wants to merge 3 commits into
otter-sec:anchor-nextfrom
jamie-osec:fix/v2-remaining-accounts-mut-check

Conversation

@jamie-osec
Copy link
Copy Markdown
Collaborator

No description provided.

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 22, 2026

@jamie-osec is attempting to deploy a commit to the Solana Foundation Team on Vercel.

A member of the Team first needs to authorize it.

@jamie-osec jamie-osec requested a review from chen-robert April 22, 2026 14:54
Comment thread lang-v2/src/context.rs Outdated
@jamie-osec jamie-osec force-pushed the fix/v2-remaining-accounts-mut-check branch from 4b4da7c to 9063750 Compare April 23, 2026 20:36
@jamie-osec
Copy link
Copy Markdown
Collaborator Author

The IxArgs and token-2022 PRs caused some issues

Comment thread lang-v2/src/context.rs Outdated
Comment thread lang-v2/src/context.rs Outdated
@jamie-osec jamie-osec force-pushed the fix/v2-remaining-accounts-mut-check branch from 9063750 to 9c1c907 Compare April 24, 2026 10:30
@0x4ka5h
Copy link
Copy Markdown
Collaborator

0x4ka5h commented Apr 27, 2026

can you rebase and resolve conflicts, so I can review?

@jamie-osec jamie-osec force-pushed the fix/v2-remaining-accounts-mut-check branch from 9c1c907 to 57f1d91 Compare April 28, 2026 12:15
Copy link
Copy Markdown
Collaborator

@0x4ka5h 0x4ka5h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jamie-osec jamie-osec force-pushed the fix/v2-remaining-accounts-mut-check branch from 57f1d91 to a1ac9ad Compare May 8, 2026 14:34
@jamie-osec jamie-osec force-pushed the fix/v2-remaining-accounts-mut-check branch from a1ac9ad to 42997da Compare May 8, 2026 16:08
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 80.48780% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.62%. Comparing base (b05ddb2) to head (42997da).
⚠️ Report is 1 commits behind head on anchor-next.

Files with missing lines Patch % Lines
lang-v2/src/dispatch.rs 14.28% 6 Missing ⚠️
lang-v2/src/context.rs 93.54% 2 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           anchor-next    #4441      +/-   ##
===============================================
+ Coverage        62.96%   63.62%   +0.66%     
===============================================
  Files               50       51       +1     
  Lines             6189     6497     +308     
===============================================
+ Hits              3897     4134     +237     
- Misses            2292     2363      +71     
Flag Coverage Δ
v2 63.62% <80.48%> (+0.66%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants