Fix inner instruction events not being detected#4451
Open
Matthias1590 wants to merge 7 commits into
Open
Conversation
|
@Matthias1590 is attempting to deploy a commit to the Solana Foundation Team on Vercel. A member of the Team first needs to authorize it. |
0x4ka5h
requested changes
Apr 23, 2026
Collaborator
0x4ka5h
left a comment
0x4ka5h
left a comment
There was a problem hiding this comment.
Prefer matching inner invoke with the same regex as the first log and only then push if the captured id equals this program. Also Could you please mirror the change in client/lib.rs and add a small parseLogs test there aswell.
Author
|
Will do |
Author
|
Requested changes are made. The added test failed pre-edit and passed afterwards, as expected. |
Author
|
Formatting is fixed now |
Author
|
Will this be merged? Constantly syncing my fork up to date for my projects is getting annoying :p |
Author
|
Bump |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4450 by removing the "log:" part of the log check, if a log line starts with
Program ${programId.toString()}it belongs to programId, whether it's a log, or invoke.