Fix: Improve anchor program deploy reliability with resumable buffers#4531
Fix: Improve anchor program deploy reliability with resumable buffers#4531swaroop-osec wants to merge 11 commits into
Conversation
|
@swaroop-osec is attempting to deploy a commit to the Solana Foundation Team on Vercel. A member of the Team first needs to authorize it. |
Greptile SummaryThis PR overhauls
Confidence Score: 3/5The deploy/upgrade paths work correctly for the common case, but the persistent-buffer resume logic has a correctness gap when the user shrinks the program binary after a failed full-buffer-write attempt. The stale-tail-bytes issue can silently deploy a corrupted program binary or fail ELF verification in a scenario the PR was specifically designed to handle — fully-written buffer, failed upgrade tx, then a smaller binary on retry. cli/src/program.rs deserves a close second look, particularly the oversized-buffer case in both Important Files Changed
Reviews (1): Last reviewed commit: "fix(cli): ensure deploy directory is val..." | Re-trigger Greptile |
Summary
anchor program deployandanchor program upgraderesumable across retries and reruns using persistent per-program buffer keypairs.--skip-preflightconsistently across buffer writes, deploys, upgrades.Closes #4481