This repository was archived by the owner on Aug 23, 2026. It is now read-only.
Repository navigation
Remove rancher - #147
Merged
Merged
Remove rancher#147
Conversation
There was a problem hiding this comment.
Pull request overview
Removes Rancher-related API surface area from the Link API and Workspace CRD by deleting the Rancher project field(s)/RPC and updating all generated artifacts (Go, TS, OpenAPI, CRD) to match the new protobuf schema.
Changes:
- Removed
rancher_project_idfields and theListRancherProjectsRPC/messages fromproto/link/v1/link.proto. - Regenerated Go/TS protobuf + Connect stubs and pruned OpenAPI schema/paths accordingly.
- Removed
spec.rancherProjectIDfrom the Workspace API type and CRD schema.
Reviewed changes
Copilot reviewed 5 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| ts/src/link/v1/link_pb.js | Regenerated JS protobuf descriptors after removing Rancher messages/fields. |
| ts/src/link/v1/link_pb.d.ts | Regenerated TS declarations to remove Rancher types/fields and RPC. |
| tenant/v1alpha1/workspace_types.go | Removes RancherProjectID from WorkspaceSpec. |
| proto/link/v1/link.proto | Removes Rancher RPC/messages/fields from the Link API schema. |
| openapi/openapi.yaml | Removes Rancher RPC endpoint + schema properties from OpenAPI. |
| link/v1/link.pb.go | Regenerated Go protobuf types to match the updated proto schema. |
| link/v1/link.connect.go | Regenerated Connect client/handler to remove ListRancherProjects. |
| config/crd/bases/tenant.otterscale.io_workspaces.yaml | Updates CRD schema to remove spec.rancherProjectID. |
Files not reviewed (2)
- link/v1/link.connect.go: Generated file
- link/v1/link.pb.go: Generated file
Suppressed comments (2)
proto/link/v1/link.proto:98
GetAgentManifestRequestremovedrancher_project_id(tag 3) but doesn’t reserve the tag/name. Reserving removed tags/names helps keep the protobuf schema forward-compatible and prevents accidental reuse.
repeated string extra_users = 2;
}
proto/link/v1/link.proto:68
RegisterRequestremovedrancher_project_id(tag 5) but doesn’t reserve the field number/name. Reserving removed tags/names is recommended to avoid future accidental reuse and hard-to-debug compatibility issues.
string agent_version = 4;
}
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
41
to
42
| string agent_version = 2; | ||
|
|
||
| // The full Rancher Project identifier in "<cluster-id>:<project-name>" form. | ||
| string rancher_project_id = 3; | ||
| } | ||
|
|
||
| // RancherProject identifies a Rancher Project available for cluster | ||
| // registration. | ||
| message RancherProject { | ||
| // The full Rancher Project identifier in "<cluster-id>:<project-name>" form. | ||
| string id = 1; | ||
|
|
||
| // The human-readable Rancher Project name. | ||
| string display_name = 2; | ||
| } | ||
|
|
||
| // ListRancherProjectsRequest is an empty request message for listing Rancher | ||
| // Projects. | ||
| message ListRancherProjectsRequest {} | ||
|
|
||
| // ListRancherProjectsResponse contains the available Rancher Projects. | ||
| message ListRancherProjectsResponse { | ||
| // The available Rancher Projects. | ||
| repeated RancherProject projects = 1; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.