Repository navigation
Merge 1.5.5 - #747
Merged
Merged
Merge 1.5.5#747
Conversation
The column read `spec.running`, but every VM here is created with `spec.runStrategy` and started or stopped through the subresource API, which only flips runStrategy. KubeVirt forbids both fields on one VM, so `spec.running` was never set and the cell stayed blank next to a Status of Running. Status already shows the actual state from `status.printableStatus`, and kubectl's wide output has no Running column either, so remove it rather than derive it from runStrategy. (cherry picked from commit 53265af)
Each JSON Schema error on submit raised a persistent toast whose description was the raw error path (e.g. `[3.subject]`). Since #653 records error toasts, these flooded the notification centre and QA reported the path as a bug. The same errors are already shown inline under their fields with the first one focused, so remove the toasts and the state that only fed them. Server-side failures still toast via each action's toast.promise. Co-authored-by: Zhang, En-Yao <76697563+ZhangEnYao@users.noreply.github.com> (cherry picked from commit 65d7216)
Co-authored-by: george-wu20250203 <george_wu@phison.com> (cherry picked from commit 1e55fe0)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.