Add role for the GCP VM Scanner. Refresh docs.#42
Open
grzr wants to merge 2 commits into
Open
Conversation
mrahbar
suggested changes
Mar 2, 2026
mrahbar
reviewed
Mar 26, 2026
| description = "Permissions for Pantheon to be able scan machine snapshots and list instances." | ||
| permissions = [ | ||
| "compute.snapshots.create", | ||
| "compute.instances.list" |
Contributor
There was a problem hiding this comment.
- what about "compute.snapshots.delete"
- why is "compute.instances.list" necessary if engine has already the perission. Otherwise if necessary isn't "compute.instances.get" missing?
mrahbar
reviewed
Mar 26, 2026
| description = "The ID of the organization that owns the resources that you want to scan. Needs to be set by user. Either org_id or folder_ids must be set." | ||
| } | ||
|
|
||
| variable "folder_ids" { |
Contributor
There was a problem hiding this comment.
lately single project onboarding was added for GCP. should this be supported here as well?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.