Skip to content

refactor(gcp-permission): use index-based for_each for computed roles #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KaanTolunayKilicOG wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor(gcp-permission): use index-based for_each for computed roles #45

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion terraform/modules/gcp-permission/folder.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

# Iterate over the permutation of all roles and folderIds
resource "google_folder_iam_member" "folder_level_permissions" {
for_each = local.is_folder_level ? { for entry in local.folder_roles : "${entry.role}.${entry.folderId}" => entry } : {}
for_each = local.is_folder_level ? { for idx, entry in local.folder_roles : idx => entry } : {}
folder = each.value.folderId
member = "serviceAccount:${var.pantheon_service_account}"
role = each.value.role
Expand Down
2 changes: 1 addition & 1 deletion terraform/modules/gcp-permission/project.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

# Iterate over the permutation of all roles and projectIDs
resource "google_project_iam_member" "project_level_permissions" {
for_each = local.is_project_level ? { for entry in local.project_roles : "${entry.role}.${entry.projectId}" => entry } : {}
for_each = local.is_project_level ? { for idx, entry in local.project_roles : idx => entry } : {}
project = each.value.projectId
member = "serviceAccount:${var.pantheon_service_account}"
role = each.value.role
Expand Down