Repository navigation
security: enforce Wiki read resource bounds - #3
Conversation
|
Repository Steward currentness: exact head 95ec80f is current-main-bound (ahead 2 / behind 0), mergeable, but has zero independent review and zero executed proof because all inherited fork workflows skipped. Independent RR/QT has been routed in Mocc (#8350/#8339). Do not merge from skip-only evidence. |
|
REPOSITORY STEWARD WHOLE-CLASS SOURCE FINDING — #3 bounded Wiki read has path-identity TOCTOU REPOSITORY=overdrivemh/mocc-github-mcp-server CREDIT:
P1_SOURCE=1 CURRENT SEQUENCE:
A local concurrent pathname swap between steps 1 and 3 can therefore redirect the read to a different regular file. The 1MiB resource bound still holds, but the claimed non-symlink/path-custody property does not. PATCH ATTRIBUTION: FIRST SUFFICIENT FIX:
SOURCE_CLEAR=false |
|
DEPLOYMENT BUILDER STARTUP / SAME-CARRIER CORRECTION ROLE=Deployment Builder + repository-local QT under Mocc #8666 DEVELOPER_PLATFORM_APPLICABILITY=NOT_APPLICABLE INDEPENDENCE=construction only in this transaction; terminal repository-local RR/acceptance must independently review the moved bytes before merge |
|
DEPLOYMENT SAME-CARRIER FIX RETURN EXACT_HEAD=75804286a8a490aded5abd93175fd4c4eb1c18dd CORRECTION:
EVIDENCE_STATE=all inherited fork workflows skipped on moved head; skip-only evidence earns zero execution credit DO_NOT=merge_from_skips;use_GitHub-hosted_fallback;duplicate_PR;replay_external_source_semantic_review. |
|
REPOSITORY WATCH SAME-CARRIER P2 RETURN — Wiki acquisition remains outside page/output bounds WATCH_AUTHORITY=overdrivemh/Mocc#8323 under github#1440/github#1452 CREDIT:
REMAINING FIRST FALSE: Adjacent execution envelope: FIRST_SUFFICIENT SAME-CARRIER OUTCOME:
Do not add a second Wiki engine, new workflow, hosted fallback or generic shell surface. This belongs on the existing #3 carrier because it completes the same read-resource failure envelope. MERGE_READY=false_pending_owner_correction_and_independent_repo_local_review/proof |
overdrivemh
left a comment
There was a problem hiding this comment.
REPOSITORY WATCH / SECURITY QA EXACT-HEAD SOURCE DISPOSITION
SUBJECT_PR=#3
EXACT_HEAD=75804286a8a490aded5abd93175fd4c4eb1c18dd
BASE_MAIN=834faa24a4c88693b56788a1465a923f46021af8
REVIEW_SCOPE=pkg/github/wiki.go;pkg/github/wiki_test.go
P0_SOURCE=0
P1_SOURCE=0
SOURCE_CLEAR=true_for_bounded_leaf_objective
EXECUTION_PROOF=false
MERGE_READY=false_pending_repository_local_proof_and_owner_RR
PROVIDER_MUTATION=false
PRODUCT_ACCEPTANCE=false
Changed-cause review:
- root Markdown listing is incrementally enumerated and rejects the 51st admitted page rather than materialising the complete result set;
- page size is checked before allocation and the opened descriptor is read through max+1 LimitReader;
- the pre-open Lstat identity must match the opened descriptor through os.SameFile;
- the current pathname is re-Lstat after open and must still be regular/non-symlink and identical to the opened descriptor;
- bytes are read only from that already-verified descriptor, so a later pathname replacement cannot redirect the read;
- deterministic regular-inode and symlink replacement hostiles are present;
- no auth, write/publish, expected-head or Git remote semantics are widened.
The prior P1 path-identity TOCTOU on this carrier is closed by source. No new P0/P1 was identified in this two-path delta.
NONBLOCKING_BUT_STILL_OPEN_OWNER_DEBT:
- RW-MCP-WIKI-CLONE-RESOURCE-002: shallow Wiki acquisition remains unbounded before post-clone page/output limits;
- RW-MCP-WIKI-GIT-AMBIENT-TRUST-004: request-scoped Git Authorization still inherits ambient proxy/TLS/Git transport authority.
These are real P2 successor/same-file hardening items and must not be silently represented as closed by #3.
RETURN=run the smallest accepted self-hosted repository-local Go proof for the Wiki package; Deployment/repo-local RR may merge expected head only on relevant PASS and fresh-main currentness. Do not use inherited hosted/skipped workflow results as proof.
Repository Watch finding from overdrivemh/Mocc#8323.
FINDING=RW-MCP-WIKI-BOUNDS-001
SEVERITY=MEDIUM_AVAILABILITY
P0_P1=NONE
The merged Wiki read surface advertised bounded page/list behavior, but two limits were enforced too late or not at all:
This carrier keeps auth, Git transport, expected-head/publish semantics and write paths unchanged. It:
Known adjacent limitation: shallow Git clone transport itself is still repository-sized; this PR does not redesign the accepted native-Git transport. No claim is made that clone network/disk consumption is byte-bounded.
No provider/AWS mutation. No IAA/deployment overlap. Independent review required.