-
-
Notifications
You must be signed in to change notification settings - Fork 565
Replace PHP CS Fixer with Laravel Pint for code formatting #377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: overtrue <1472352+overtrue@users.noreply.github.com>
Co-authored-by: overtrue <1472352+overtrue@users.noreply.github.com>
pint.json
Outdated
| @@ -0,0 +1,3 @@ | |||
| { | |||
| "preset": "symfony" | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot laravel
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed to Laravel preset in commit 8adf754. All 95 files reformatted with Laravel coding standards.
Co-authored-by: overtrue <1472352+overtrue@users.noreply.github.com>
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
This PR migrates the code formatting tool from
friendsofphp/php-cs-fixertolaravel/pintas requested in the issue.Changes
Dependencies
friendsofphp/php-cs-fixerwithlaravel/pintin composer.json require-devConfiguration
.php-cs-fixer.dist.phpconfiguration filepint.jsonwith Laravel preset to apply Laravel coding standards.gitignoreto include.pint.cacheComposer Scripts
Updated the following composer scripts to use Pint:
check-style: Now runspint --test(checks for style issues without fixing)fix-style: Now runspint(fixes all style issues)fix: New command added as requested - runspintto format codeCode Formatting
Ran Pint to format all existing code according to the Laravel preset. Formatting changes were applied to 87 files with 86 style issues fixed:
!isset()→! isset())Benefits
composer fixcommand for quick formattingTesting
All existing functionality has been verified:
Usage
Fixes the requirement to use Laravel Pint as the code formatting tool and add a
composer fixcommand.Original prompt
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.