Skip to content

Check that every rev reference agrees with the policy block - #5

Merged
ovhirup merged 2 commits into
mainfrom
ci-rev-checks
Oct 1, 2026
Merged

ovhirup merged 2 commits into
mainfrom
ci-rev-checks

Conversation

@ovhirup

@ovhirup ovhirup commented Oct 1, 2026

Copy link
Copy Markdown
Owner

What

CI-only change to .github/workflows/validate.yml. Bumping policy-rev and versions in 3.1.0 and 3.1.1 needed manual greps because CI did not catch a missed reference.

  • Line 50 no longer hard-codes policy-rev: 5. It requires exactly one whole-line <!-- policy-rev: N --> in SKILL.md, so a bump needs no workflow edit.
  • New step "Revision references agree" (stdlib-only python3) reads the rev from inside the policy block and requires these to match it:
    • the SKILL.md frontmatter policy-rev
    • the step-4 text ("policy-rev: N is present inside the block")
    • evals cases 1 and 2
    • each port's README stackwich-<port>-rev N mention vs. the rev comment inside that port's own block

Every check is region-scoped or a whole-line match, since these files document their own marker syntax in prose and substring greps have matched the documentation before.

Not in this PR

No policy block change, so no policy-rev bump, version bump, CHANGELOG entry, tag, or ~/.claude sync. Same precedent as #2. Ships with the next release.

Verification

  • Local harness (each step's run: text through bash): 9 of 9 PASS on the real repo, revisions OK among them.
  • 8 single-mutation scratch copies each failed with the expected message (frontmatter rev, step-4 text, evals case 1, case 2, grok rev without README, codex README drift, block rev changed, rev comment moved outside the block). In the grok case the old "Grok port well-formed" step still passed, so the old checks alone would have missed it.
  • Advisor reviewed the diff: APPROVE. Not yet run on a real GitHub Actions runner; this PR's own validate run is that check.

Before merging

Read all reviews and comments, wait for the Codex review on this head commit, and confirm the validate run shows the new step passing.

🤖 Generated with Claude Code

A rev bump touched several places CI did not check. Add a stdlib-only
step that reads the rev from inside the policy block and requires the
frontmatter policy-rev, the step-4 text, evals cases 1 and 2, and each
port's README rev to agree with their sources. Line 50 no longer
hard-codes the rev, so a bump needs no workflow edit.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b1f399e9a9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/validate.yml Outdated
The revision step matched any indented "policy-rev: N" line anywhere in
the SKILL.md frontmatter, so moving it under another mapping still
passed. Require exactly one whole-line "metadata:" key in the
frontmatter and exactly one "  policy-rev: N" among its directly
indented lines, with clear errors when either is missing or duplicated.
Still stdlib-only.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@ovhirup

ovhirup commented Oct 1, 2026

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Swish!

Reviewed commit: c433e6b4d7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@ovhirup
ovhirup merged commit 271bf83 into main Oct 1, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant