fix: harden runtime state and job output - #156
Merged
Merged
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 32e1be6602
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
owainlewis
force-pushed
the
codex/main-hardening
branch
from
July 25, 2026 22:58
32e1be6 to
7379868
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
push job listWhy
The main branch was red because the public job example contained a machine-specific workdir and enabled schedule. Runtime state and audit logs also relied on umask despite containing sensitive metadata, and malformed job filenames could inject rows or terminal controls into list output.
This PR restores the missing terminal hardening from the intent of #147 without reverting main's newer table formatter. PR #152 remains the separate canonical Pi unattended-resource fix.
Verification
cargo test --all-targets(333 unit tests, 1 documentation test, 12 init CLI tests, 3 manual crash/recovery tests)cargo clippy --all-targets --all-features -- -D warningscargo build --release --lockedcargo fmt --all -- --checkgit diff --checkbash tests/release-version.shbash tests/install.shuv run --with-requirements requirements-docs.txt mkdocs build --strictRisk
Windows-specific file replacement behavior and live multi-process audit writes were not exercised. The non-Unix permission helper remains a no-op as before.