fix: handle x:Name fallback in RegisterHotKeyChange and AddRichPopover#3
Open
Nigh wants to merge 1 commit into
Open
fix: handle x:Name fallback in RegisterHotKeyChange and AddRichPopover#3Nigh wants to merge 1 commit into
Nigh wants to merge 1 commit into
Conversation
RegisterHotKeyChange() directly accessed _Props["Name"] without checking for x:Name, causing a key-not-found error on AXML-defined HotKeyBox elements that only have x:Name set. _AddRichPopover() only checked _Props["Name"], so AXML-defined elements with x:Name would bypass the existing name and get a duplicated auto-generated name instead. Both functions now follow the same Name/x:Name fallback pattern already used by Find(), _CollectInlineEvents(), and _AddRichPopoverAdv().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RegisterHotKeyChange() directly accessed _Props["Name"] without checking for x:Name, causing a key-not-found error on AXML-defined HotKeyBox elements that only have x:Name set.
_AddRichPopover() only checked _Props["Name"], so AXML-defined elements with x:Name would bypass the existing name and get a duplicated auto-generated name instead.
Both functions now follow the same Name/x:Name fallback pattern already used by Find(), _CollectInlineEvents(), and _AddRichPopoverAdv().