fix: replace GUI dialogs with stderr in CompileEngine for CLI compatibility#4
Open
Nigh wants to merge 3 commits into
Open
fix: replace GUI dialogs with stderr in CompileEngine for CLI compatibility#4Nigh wants to merge 3 commits into
Nigh wants to merge 3 commits into
Conversation
fix: remove double quotes from #Include directives for ahk2exe compatibility
…bility Replace MsgBox and ShowErrorDialog calls in CompileEngine() with _WriteConsoleW-based stderr output to allow compilation to complete in headless CLI environments such as GitHub Actions. Also replaced ToolTip calls (GUI-dependent) with stderr output.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MsgBoxandShowErrorDialogcalls inCompileEngine()withWriteConsoleW-based stderr outputToolTipcalls (GUI-dependent) with stderr outputXAMLHost._StdErr()static helper methodMotivation
In headless CLI environments such as GitHub Actions, GUI dialogs (
MsgBox,ToolTip,ShowErrorDialog) cannot be displayed, causing the compilation process to hang or fail. This change redirects all diagnostic output inCompileEngine()to stderr, allowing the build to complete and properly report errors in CI/CD pipelines.Changes
lib/XAML_Host.ahk: 4MsgBox/ShowErrorDialog+ 3ToolTipcalls replaced with_StdErr()